-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): Allow including 'File' scalar by default to be disabled #11540
Conversation
db.$disconnect() | ||
}, | ||
// highlight-start | ||
includeScalars: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better than what I had - the config is at least consistent looking between toml and Yoga config. Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! @Josh-Walker-GM
LGTM and will now let people who have had a Prisma File model opt out effectively of Uploads.
My only question is if in The Default Scalars docs or in Storage we should mention that if you opt out of the file scalar, your project will not be able to use Redwood Storage or any GraphQL file upload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please discuss this one more round before merging?
Love that this is still enabled by default and it's opt out! |
We decided we wanted to go ahead with this as a fix for the reported problem. |
…#11540) There was a problem introduced in v8 when we included the `File` scalar by default. This meant a custom implementation by the user could be clobbered by the new default. This change allows the user to supply config to disable including it by default. This is not how I would have loved to have done things here. Config in two places is rubbish but given the organisation of this currently it was generally unavoidable.
There was a problem introduced in v8 when we included the
File
scalar by default. This meant a custom implementation by the user could be clobbered by the new default. This change allows the user to supply config to disable including it by default.This is not how I would have loved to have done things here. Config in two places is rubbish but given the organisation of this currently it was generally unavoidable.