Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to confirm upgrade #11601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pantheredeye
Copy link
Collaborator

Added a prompt after running yarn rw upgrade to confirm before starting.

Motivation: I have upgraded a project twice, that I remember, on accident while looking for information about the latest upgrade. Right now, when a user runs yarn rw upgrade the process starts immediately. This check adds a simple prompt to the beginning of listr tasks to confirm if they want to upgrade the project.

Thoughts:

The prompt method is taken from other cli commands using a prompt. It defaults to adding (Y/n) >> true to the end of the prompt. I don't like the mismatch in terms. But, I can't figure out how to default it to 'yes' instead of true.

I looked for tests related to the upgrade command, but didn't find them.

Screenshots:

Prompt:
image

Upgrade Cancelled:
image

Upgrade Confirmed:
image

@pantheredeye
Copy link
Collaborator Author

Fails smoke tests... I would need to update these if this goes through. I might need to be pointed in the right direction to do this!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant