Fix build with TS alias without basePath #11693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callingmedic911
force-pushed
the
aditya/fix-build-ts-path
branch
from
9944a53
to
23d31f4
Compare
justinadkins
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
LGTM, I tested locally and path aliasing is working now. Unrelated to my ticket but one limitation of Redwood path aliasing feature currently is it requires /*. I discovered this while testing this fix. We cannot do something like: "#*": ["./src/components/*"], at the moment.
Thank you for the fix!
peterp
approved these changes
Oct 14, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Nov 14, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11686.
I think this was accidentally introduced when we removed
baseUrl. The change assumes rootDir as the fallback if there's no baseUrl (default TS behaviour).