fix(dbAuth): Don't use Multi Value Headers on Vercel #11718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-dbauth-cookies-vercel
branch
from
c86829a
to
01df61e
Compare
Tobbe
changed the title
dthyresson
approved these changes
Nov 12, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Nov 14, 2024
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vercel doesn't support
multiValueHeaders. See vercel/vercel#7820Netlify only supports
multiValueHeadersfor how we set our auth cookies: #10889So this PR tries to solve for both by adding a check for a Vercel-specific header.
I worry this will break (they might change what headers they set). But it's the best solution I could come up with for now