-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: signet rgs #147
fix: signet rgs #147
Conversation
WalkthroughThe pull request involves updating the signet network URL in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
LDKNodeMonday/Utilities/Constants.swift (2)
53-53
: Consider adding documentation for RGS endpoints.Since this is a critical infrastructure endpoint, consider adding documentation comments above the
RGSServerURLNetwork
struct explaining:
- The purpose of these endpoints
- Expected response format
- Any rate limiting or usage guidelines
Example documentation:
+ /// RGS (Rapid Graph Sync) server endpoints for different networks. + /// These endpoints provide Lightning Network graph data for rapid sync. + /// Format: Returns compressed graph data in LDK-compatible format. struct RGSServerURLNetwork {
53-53
: Ensure consistent domain usage across Mutiny services.The codebase uses multiple Mutiny-related services:
- RGS:
rgs.mutinynet.com
- Esplora API:
mutinynet.com/api
- LSP node: IP address
3.84.56.108
Consider standardizing all Mutiny services to use subdomains of mutinynet.com for better maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
LDKNodeMonday/Utilities/Constants.swift
(1 hunks)
🔇 Additional comments (1)
LDKNodeMonday/Utilities/Constants.swift (1)
53-53
: Verify the new RGS endpoint availability.The signet RGS server URL is being updated to use the Mutiny domain. Please ensure:
- The new endpoint is operational and accessible
- The change has been coordinated with the Mutiny team
Let's verify the endpoint availability:
Description
Corrected RGS.
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-format
fileNew Features:
Bugfixes: