Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signet rgs #147

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: signet rgs #147

merged 1 commit into from
Jan 15, 2025

Conversation

reez
Copy link
Owner

@reez reez commented Jan 15, 2025

Description

Corrected RGS.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I have formatted my code with swift-format per .swift-format file

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request involves updating the signet network URL in the Constants.swift file. The change replaces the existing signet server URL with a new endpoint, specifically modifying the RGSServerURLNetwork struct's signet static constant from "https://mutinynet.lspd.lqwd.tech" to "https://rgs.mutinynet.com/".

Changes

File Change Summary
LDKNodeMonday/Utilities/Constants.swift Updated RGSServerURLNetwork.signet URL from "https://mutinynet.lspd.lqwd.tech" to "https://rgs.mutinynet.com/"

Poem

🐰 A URL hops to a new domain,
Signet's path takes a fresh refrain,
From lspd to rgs it leaps,
A network change that softly creeps,
Mutinynet's new digital lane! 🌐


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
LDKNodeMonday/Utilities/Constants.swift (2)

53-53: Consider adding documentation for RGS endpoints.

Since this is a critical infrastructure endpoint, consider adding documentation comments above the RGSServerURLNetwork struct explaining:

  • The purpose of these endpoints
  • Expected response format
  • Any rate limiting or usage guidelines

Example documentation:

+       /// RGS (Rapid Graph Sync) server endpoints for different networks.
+       /// These endpoints provide Lightning Network graph data for rapid sync.
+       /// Format: Returns compressed graph data in LDK-compatible format.
        struct RGSServerURLNetwork {

53-53: Ensure consistent domain usage across Mutiny services.

The codebase uses multiple Mutiny-related services:

  • RGS: rgs.mutinynet.com
  • Esplora API: mutinynet.com/api
  • LSP node: IP address 3.84.56.108

Consider standardizing all Mutiny services to use subdomains of mutinynet.com for better maintainability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2db00f and 11014dd.

📒 Files selected for processing (1)
  • LDKNodeMonday/Utilities/Constants.swift (1 hunks)
🔇 Additional comments (1)
LDKNodeMonday/Utilities/Constants.swift (1)

53-53: Verify the new RGS endpoint availability.

The signet RGS server URL is being updated to use the Mutiny domain. Please ensure:

  1. The new endpoint is operational and accessible
  2. The change has been coordinated with the Mutiny team

Let's verify the endpoint availability:

@reez reez merged commit 388cc3d into main Jan 15, 2025
1 check passed
@reez reez deleted the rgs branch January 15, 2025 14:12
@coderabbitai coderabbitai bot mentioned this pull request Jan 15, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant