spm: update simpletoast + codescanner + ldknode

[reez]

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I have formatted my code with swift-format per .swift-format file

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

Summary by CodeRabbit

• Dependency Updates
  • Updated ldk-node package to version 0.4.2
  • Updated SimpleToast package to version 0.10.1
  • Updated CodeScanner package to version 2.5.2
• Improvements
  • Enhanced logging initialization with network-specific directory creation.
  • Improved error handling in ldkNode initialization.
• Code Cleanup
  • Removed non-functional line from the delete method in SettingsViewModel.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 SwiftLint (0.57.0)

LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift

[
{
"character" : 35,
"file" : "/LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift",
"line" : 24,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 13,
"file" : "/LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift",
"line" : 26,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
},
{
"character" : 23,
"file" : "/LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift",
"line" : 99,
"reason" : "Force tries should be avoided",
"rule_id" : "force_try",
"severity" : "Error",
"type" : "Force Try"
}
]

Walkthrough

The pull request involves updating the version requirements for several Swift package dependencies in the Xcode project configuration file. Specifically, the versions of ldk-node, SimpleToast, and CodeScanner have been incremented. Additionally, the LightningNodeService.swift file has been modified to enhance the logging directory creation and improve error handling during initialization. A minor change was made in the SettingsViewModel.swift file by removing a non-functional line from the delete method.

Changes

File	Change Summary
LDKNodeMonday.xcodeproj/project.pbxproj	Updated package versions: - ldk-node: 0.4.0 → 0.4.2 - SimpleToast: 0.8.1 → 0.10.1 - CodeScanner: 2.0.0 → 2.5.2
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift	Added directory creation for logging based on network type in the initializer. Improved error handling for ldkNode initialization.
LDKNodeMonday/View Model/Profile/SettingsViewModel.swift	Removed a non-functional line in the delete method of SettingsViewModel.

Possibly related PRs

• chore: add log dir #97: This PR adds a log directory in LightningNodeService.swift, which is related to the changes in the main PR that also involve logging directory creation.
• Network specific storage paths #149: This PR modifies the initialization of the LightningNodeService class, including improvements to error handling and the configuration of storage paths, which aligns with the changes made in the main PR regarding the initialization logic and error handling.

Poem

🐰 Hop, hop, dependencies grow!
Swift packages dancing to and fro
Version numbers climbing high
Upgrades that make our code fly
Rabbit's code magic, smooth and light 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab1e5e4 and db138f3.

📒 Files selected for processing (2)

• LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift (1 hunks)
• LDKNodeMonday/View Model/Profile/SettingsViewModel.swift (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• LDKNodeMonday/View Model/Profile/SettingsViewModel.swift

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.