Fix poseStack translation leak in JEI RecipeTransferCraftingGridError#3718
Closed
mezz wants to merge 1 commit intorefinedmods:developfrom
Closed
Fix poseStack translation leak in JEI RecipeTransferCraftingGridError#3718mezz wants to merge 1 commit intorefinedmods:developfrom
mezz wants to merge 1 commit intorefinedmods:developfrom
Conversation
Author
|
Note this issue does not exist in |
Collaborator
|
Thx for the PR, but RS1 is no longer maintained. Fixed in RS2 like you said. |
Author
|
Congrats on the RS2 release @raoulvdberge 👍 |
Collaborator
|
Thank you <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
RS has a
poseStack.translatewith pushing and popping the stack, resulting in a leaked translation.Before fix, hovering over the crafting button would shift GUI elements around:
After fix:
I added mitigation for this in JEI as well but I think this is the "correct" place for the fix to be.