feat: minified state names #3701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Jul 25, 2024
reflex/constants/compiler.py
Outdated
| # The env var to toggle minification of states. | ||
| ENV_MINIFY_STATES = "REFLEX_MINIFY_STATES" | ||
| # Whether to minify states. | ||
| MINIFY_STATES = os.environ.get(ENV_MINIFY_STATES, False) |
There was a problem hiding this comment.
i'm thinking we should minify state names by default in prod mode
There was a problem hiding this comment.
I agree. Should we also move this to rx.Config.minify_states?
masenf
reviewed
Jul 25, 2024
There was a problem hiding this comment.
unfortunately trying to run it on reflex-web is giving a cryptic error
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/pcweb.py", line 8, in <module>
from pcweb.pages import page404, routes
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/pages/__init__.py", line 3, in <module>
from .blog import blog_routes
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/pages/blog/__init__.py", line 1, in <module>
from .blog import *
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/pages/blog/blog.py", line 2, in <module>
from pcweb.templates.webpage import webpage
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/templates/__init__.py", line 1, in <module>
from .docpage import docpage
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/templates/docpage/__init__.py", line 1, in <module>
from .docpage import *
File "/Users/masenf/code/reflex-dev/reflex-web/pcweb/templates/docpage/docpage.py", line 545, in <module>
class RadixDocState(rx.State):
File "pydantic/main.py", line 282, in pydantic.main.ModelMetaclass.__new__
File "<frozen abc>", line 106, in __new__
File "/Users/masenf/code/reflex-dev/reflex/reflex/state.py", line 563, in __init_subclass__
raise StateValueError(
reflex.utils.exceptions.StateValueError: The substate class 'a' has been defined multiple times. Shadowing substate classes is not allowed.
masenf
reviewed
Jul 25, 2024
masenf
reviewed
Jul 25, 2024
benedikt-bartscher
changed the title
benedikt-bartscher
force-pushed
the
minify-state-names
branch
2 times, most recently
from
3c1946d
to
337f4cb
Compare
|
Superseded by #3728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup of #3214