-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only serialize used rx.Base fields #3845
Draft
abulvenz
wants to merge
12
commits into
reflex-dev:main
Choose a base branch
from
abulvenz:do-not-serialize-unused-rxbase-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Only serialize used rx.Base fields #3845
abulvenz
wants to merge
12
commits into
reflex-dev:main
from
abulvenz:do-not-serialize-unused-rxbase-fields
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only for rx.Base objects.
Merge remote-tracking branch 'upstream/main' into do-not-serialize-unused-rxbase-fields
Merge remote-tracking branch 'upstream/main' into do-not-serialize-unused-rxbase-fields
@abulvenz I think we can rebase this and mark it as ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you check the payloads when running the example below, you might notice that
value
is only serialized when you comment in line 43 where thevalue
is displayed.Fields are checked on class level, so always the union of all used fields will be serialized (Not per usage, which would be cool, but more sophisticated.)