Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3935]Deprecate Starlette-admin in favor of model_wrapper in reflex-ag-grid #4207

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElijahAhianyo
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@ElijahAhianyo
Copy link
Collaborator Author

Keeping this as a draft so we can reference the actual section link to the model_wrapper API docs on reflex-web when its available

@ElijahAhianyo ElijahAhianyo changed the title Deprecate Starlette-admin in favor of model_wrapper in reflex-ag-grid [ENG-3935]Deprecate Starlette-admin in favor of model_wrapper in reflex-ag-grid Oct 21, 2024
Copy link

linear bot commented Oct 21, 2024

@ElijahAhianyo ElijahAhianyo changed the title [ENG-3935]Deprecate Starlette-admin in favor of model_wrapper in reflex-ag-grid [ENG-3935]Deprecate Starlette-admin in favor of model_wrapper in reflex-ag-grid Oct 21, 2024
@benedikt-bartscher
Copy link
Contributor

benedikt-bartscher commented Oct 21, 2024

Could we maybe also make starlette-admin an optional dependency?
iirc we would need to:

  • put starlette-admin in a separate poetry dep group (which is installed by default if you run poetry install, but is not included in the pypi distribution)
  • add try/catch around all starlette-admin imports/usage

@masenf
Copy link
Collaborator

masenf commented Oct 21, 2024

Could we maybe also make starlette an optional dependency?

Currently starlette is a key dependency of fastapi which we use to configure the backend. I suppose it could become optional for apps which don't use backend at all, but this is not really reflex's core use case.

I think it would be nice to at least get rid of the fastapi dependency and use starlette and python-engineio more directly, but i don't know when we'd be able to prioritize that.

@benedikt-bartscher
Copy link
Contributor

benedikt-bartscher commented Oct 21, 2024

@masenf sorry, I meant starlette-admin, not starlette.

However, it would still be cool if we could get rid of a hard fastapi dep in the long term.

@benedikt-bartscher
Copy link
Contributor

  • put starlette-admin in a separate poetry dep group (which is installed by default if you run poetry install, but is not included in the pypi distribution)

we could also add it as an extra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants