Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stuff with bun_path #4688

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix stuff with bun_path #4688

wants to merge 6 commits into from
+43 −36

Conversation

Lendemor
Copy link
Collaborator

Fix #3791

@adhami3310
Copy link
Member

not to nitpick too much, but can't we make which return Path for sure? every place we call it we convert it almost immediately

@Lendemor
Copy link
Collaborator Author

not to nitpick too much, but can't we make which return Path for sure? every place we call it we convert it almost immediately

I'm fine with the idea, do you want the change in this PR? or a follow up ?

@adhami3310
Copy link
Member

do you want the change in this PR? or a follow up ?

your call

@adhami3310 adhami3310 closed this Jan 24, 2025
@adhami3310 adhami3310 reopened this Jan 24, 2025
masenf
masenf requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops marked approve with the tests failing 🤦

@Lendemor Lendemor requested a review from masenf January 24, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf Awaiting requested review from masenf

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reflex installs Bun even though BUN_PATH is set
3 participants
@Lendemor @adhami3310 @masenf