Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lowercase datatypes typing #4843

Merged
merged 16 commits into from
Mar 1, 2025
Merged

use lowercase datatypes typing #4843

merged 16 commits into from
Mar 1, 2025

Conversation

adhami3310
Copy link
Member

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 18, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4843 will improve performances by 3.04%

Comparing use-lowercase-datatypes-typing (090639b) with main (e425624)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_get_all_imports[_simple_page] 472.9 µs 458.9 µs +3.04%

@adhami3310
Copy link
Member Author

The only exception to this seems to be Dict inside of ClassVar, which fails in a weird way?

@adhami3310 adhami3310 marked this pull request as ready for review February 18, 2025 22:35
@adhami3310
Copy link
Member Author

adhami3310 commented Feb 26, 2025 •
edited
Loading

blocked on reflex-dev/reflex-web#1224

@adhami3310
Copy link
Member Author

not blocked anymore

masenf
masenf reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR kills github ui perf 😢

masenf
masenf reviewed Mar 1, 2025
View reviewed changes
masenf
masenf approved these changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a glorious act of true maintainership 🫡

@adhami3310 adhami3310 merged commit b5e5ec0 into main Mar 1, 2025
43 checks passed
@adhami3310 adhami3310 deleted the use-lowercase-datatypes-typing branch March 1, 2025 00:35
@adhami3310
Copy link
Member Author

a glorious act of true maintainership 🫡

all of our PRs will be busted o7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf