Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect old websockets #4953

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Disconnect old websockets #4953

merged 1 commit into from
Mar 14, 2025

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Mar 12, 2025

Disconnect websockets more aggressively

  • page beforeunload and unload
  • when a new event comes in for the same token with a different sid (removed in this PR)

Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #4953 will not alter performance

Comparing masenf/disconnect-old-websockets (486de31) with main (8f313ad)

Summary

✅ 12 untouched benchmarks

@Lendemor
Copy link
Collaborator

Related to #4607 I think.

Disconnecting on new sid for same token means the original page will get disconnected?

@masenf
Copy link
Collaborator Author

masenf commented Mar 12, 2025

Disconnecting on new sid for same token means the original page will get disconnected?

yes; this is intended to handle the case where page is refreshed (in an iframe) or hot reloaded and ends up with a new websocket, but never closes out the old one.

that said, i think the frontend logic might be good enough, and i wasn't actually able to hit that log message during actual testing.

@masenf masenf force-pushed the masenf/disconnect-old-websockets branch from 5d1d66c to 486de31 Compare March 14, 2025 20:03
@masenf masenf merged commit 2f33fef into main Mar 14, 2025
43 checks passed
@masenf masenf deleted the masenf/disconnect-old-websockets branch March 14, 2025 20:48
bhatia2akshit pushed a commit to bhatia2akshit/reflex that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants