Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Objectvar.get, Closes #4928 #4956

Merged
merged 5 commits into from
Mar 13, 2025

Conversation

benedikt-bartscher
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #4956 will not alter performance

Comparing benedikt-bartscher:objectvar-get (f2e1a2a) with main (b0ddceb)

Summary

✅ 12 untouched benchmarks

@adhami3310
Copy link
Member

that looks good, do you want to open it for review?

@benedikt-bartscher benedikt-bartscher changed the title add Objectvar.get, wip #4928 add Objectvar.get, Closes #4928 Mar 13, 2025
@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review March 13, 2025 18:33
@benedikt-bartscher
Copy link
Contributor Author

that looks good, do you want to open it for review?

Yeah, I think it's ready, sorry I got distracted. Thanks for your feedback!

@adhami3310
Copy link
Member

i will improve typing in a later commit, this is good for now o7

@adhami3310 adhami3310 merged commit 8996929 into reflex-dev:main Mar 13, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants