Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print warning instead of error with invalid icon #4959

Merged
merged 4 commits into from
Mar 14, 2025

Conversation

adhami3310
Copy link
Member

console.warning or console.error 🤔

Copy link

codspeed-hq bot commented Mar 13, 2025

CodSpeed Performance Report

Merging #4959 will not alter performance

Comparing print-warning-instead-of-error-with-invalid-icon (e1252fc) with main (b0ddceb)

Summary

✅ 12 untouched benchmarks

@masenf masenf merged commit 5190ff2 into main Mar 14, 2025
43 checks passed
@masenf masenf deleted the print-warning-instead-of-error-with-invalid-icon branch March 14, 2025 19:13
bhatia2akshit pushed a commit to bhatia2akshit/reflex that referenced this pull request Mar 15, 2025
* print warning instead of error with invalid icon

* dang it darglint

* pyi

* fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants