Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_parent_state and get_root_state when using mixin=True #4976

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Mar 17, 2025

If a state class inherits directly from a mixin class, find the proper parent class by looking through the mro() until a non-mixin class is found.

If a state class inherits directly from a mixin class, find the proper parent
class by looking through the `mro()` until a non-mixin class is found.
Copy link

codspeed-hq bot commented Mar 17, 2025

CodSpeed Performance Report

Merging #4976 will not alter performance

Comparing masenf/mixin-get-parent-state (f1aecd8) with main (346bce0)

Summary

✅ 12 untouched benchmarks

@adhami3310 adhami3310 merged commit d45e569 into main Mar 17, 2025
42 of 43 checks passed
@adhami3310 adhami3310 deleted the masenf/mixin-get-parent-state branch March 17, 2025 21:21
bhatia2akshit pushed a commit to bhatia2akshit/reflex that referenced this pull request Mar 19, 2025
…ex-dev#4976)

If a state class inherits directly from a mixin class, find the proper parent
class by looking through the `mro()` until a non-mixin class is found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants