-
Notifications
You must be signed in to change notification settings - Fork 0
Add scatterplots to C pages #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leburnett
wants to merge
48
commits into
main
Choose a base branch
from
issue_78_part_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update generation of cache file to include "incl_scatter" within the "roi_summary" part only for "ME", "LO" and "LOP". Uses the strict threshold service of 5% - either pre or post percentage of synapses must be >5% and there must be >50 synapses in the ROI to be included in the scatterplots.
Move selected marker on top of data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Adds interactive scatterplots to the "C" pages of types with synapses within ME, LO or LOP.
The metrics are the mean of the values calculated individually for each optic lobe side (ME(R) and ME(L) etc.)
When the page loads, the marker that represents the given type should automatically be highlighted.
A marker will only be shown if that type has > 50 synapses (across all cells) and >5% of its total synapse number within that region. This is why some types have eyemap plots that are not empty for certain regions but they don't have a marker in the corresponding scatterplot.
The cell type's marker will remain "highlighted" as you hover over other markers within the plot, but will reduce back to normal size if hovered over.
One downside to how these plots are currently generated is that they will only be "complete" if pages for all types (or optic lobe types) have been generated (e.g. using
pixi run neuview generate-all
).The plots will be made if you run
pixi run subset-medium
etc. However, the scatterplots will only have a few markers representing the cell types that have pages.