it was solved. Expecting an argument locationparserutil.kt #300 and C… #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Callback* not triggered rekabhq#301
|
It is the first time that I contribute to free code, I am open to comments. |
…and Callback* not triggered rekabhq#301
There was a problem hiding this comment.
This is a cleaner notation to achieve the intended result.
However, I'm not sure to what extent this is a solution rather than a workaround: It will work fine as a fix for now, but at least eventually it's desirable to either:
- Make sure
json[Keys.ARG_PROVIDER]is never null - Make
json[Keys.ARG_PROVIDER]nullable if it is not always present
I am not certain which of the above would be desirable, but until then this should at least fix the latest version.
|
Can we make the model Locations to, provider be of type String? And with that make the relevant changes. |
…and Callback* not triggered rekabhq#301
|
I already modified the model property. |
justjcool
approved these changes
Jan 28, 2022
|
It looks like this doesn't work as-is Did you confirm this to work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allback* not triggered #301