Merge pull request #35 from rekalogika:feat/dynamic-property-scalar

perf(`ObjectToObjectTransformer`): Prevent delegating to `MainTransformer` if the current value in a dynamic property is a scalar.
rekalogika · Feb 21, 2024 · 129ee56 · 129ee56
2 parents 9d8e927 + af8fbfa
commit 129ee56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,8 @@
 * fix: mapping to object extending `stdClass` to property with no setter.
 * feat: `stdClass` to `stdClass` mapping should work correctly.
 * feat: Mapping to existing values in a dynamic property.
+* perf(`ObjectToObjectTransformer`): Prevent delegating to `MainTransformer` if
+  the current value in a dynamic property is a scalar.
 
 ## 1.0.0
 

diff --git a/src/Transformer/Implementation/ObjectToObjectTransformer.php b/src/Transformer/Implementation/ObjectToObjectTransformer.php
@@ -587,7 +587,10 @@ private function mapDynamicProperties(
                     }
 
 
-                    if ($currentTargetPropertyValue === null) {
+                    if (
+                        $currentTargetPropertyValue === null
+                        || is_scalar($currentTargetPropertyValue)
+                    ) {
                         /** @psalm-suppress MixedAssignment */
                         $targetPropertyValue = $sourcePropertyValue;
                     } else {