Skip to content

Commit

Permalink
fix: static analysis fixes (#49)
Browse files Browse the repository at this point in the history
  • Loading branch information
priyadi committed Apr 24, 2024
1 parent 6f87e4a commit 324f3f2
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 4 deletions.
7 changes: 6 additions & 1 deletion src/CustomMapper/Implementation/PropertyMapperResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ public function getPropertyMapper(
}
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());

foreach (class_implements($targetClass) as $interface) {
$interfaces = class_implements($sourceClass);
if ($interfaces === false) {
return null;
}

foreach ($interfaces as $interface) {
if (isset($propertyMappers[$interface])) {
return $propertyMappers[$interface];
}
Expand Down
7 changes: 6 additions & 1 deletion src/CustomMapper/ObjectMapperTable.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,12 @@ public function getObjectMapper(
}
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());

foreach (class_implements($targetClass) as $interface) {
$interfaces = class_implements($sourceClass);
if ($interfaces === false) {
return null;
}

foreach ($interfaces as $interface) {
if (isset($propertyMappers[$interface])) {
return $propertyMappers[$interface];
}
Expand Down
14 changes: 12 additions & 2 deletions src/Util/TypeUtil.php
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,21 @@ private static function getAllClassesFromObject(
$class = is_object($objectOrClass) ? $objectOrClass::class : $objectOrClass;
$classes[] = $class;

foreach (class_parents($class) as $parentClass) {
$parents = class_parents($class);
if ($parents === false) {
$parents = [];
}

foreach ($parents as $parentClass) {
$classes[] = $parentClass;
}

foreach (class_implements($class) as $interface) {
$interfaces = class_implements($class);
if ($interfaces === false) {
$interfaces = [];
}

foreach ($interfaces as $interface) {
$classes[] = $interface;
}

Expand Down

0 comments on commit 324f3f2

Please sign in to comment.