if target is a list, renumber keys after deletion

rekalogika · May 1, 2024 · 4e2c1b9 · 4e2c1b9
1 parent d72143f
commit 4e2c1b9
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/src/Transformer/Implementation/TraversableToArrayAccessTransformer.php b/src/Transformer/Implementation/TraversableToArrayAccessTransformer.php
@@ -188,11 +188,24 @@ private function eagerTransform(
         // the values array
 
         if (is_array($values) && is_iterable($target)) {
+            /**
+             * @psalm-suppress RedundantConditionGivenDocblockType
+             */
+            $isList = is_array($target) && array_is_list($target);
+
             foreach ($target as $key => $value) {
                 if (!in_array($value, $values, true)) {
                     unset($target[$key]);
                 }
             }
+
+            // renumber array if it is a list
+
+            /** @psalm-suppress RedundantConditionGivenDocblockType */
+            if (is_array($target) && $isList) {
+                /** @psalm-suppress RedundantFunctionCall */
+                $target = array_values($target);
+            }
         }
 
         return $target;