fix: no longer throws exception if the target has no setter (#197)

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * style: remove unused immutability check
 * refactor: separate caching
+* fix: no longer throws exception if the target has no setter
 
 ## 1.9.1
 

src/Transformer/Util/ReaderWriter.php

@@ -13,6 +13,7 @@
 
 namespace Rekalogika\Mapper\Transformer\Util;
 
+use Psr\Log\LoggerInterface;
 use Rekalogika\Mapper\Context\Context;
 use Rekalogika\Mapper\Exception\UnexpectedValueException;
 use Rekalogika\Mapper\Transformer\Exception\NewInstanceReturnedButCannotBeSetOnTargetException;
@@ -28,11 +29,13 @@
 
 /**
  * @internal
+ * @todo inject logger
  */
 final readonly class ReaderWriter
 {
     public function __construct(
         private PropertyAccessorInterface $propertyAccessor,
+        private ?LoggerInterface $logger = null,
     ) {}
 
     /**
@@ -207,11 +210,15 @@ public function writeTargetProperty(
         if (
             $visibility !== Visibility::Public || $writeMode === WriteMode::None
         ) {
-            throw new NewInstanceReturnedButCannotBeSetOnTargetException(
-                $target,
-                $propertyMapping->getTargetProperty(),
-                context: $context,
+            $this->logger?->debug(
+                'Transformation of property {property} on object type {object_type} results in a different object instance from the original instance, but the new instance cannot be set on the target object. You may wish to add a setter method to the target class.',
+                [
+                    'property' => $propertyMapping->getTargetProperty(),
+                    'object_type' => get_debug_type($target),
+                ],
             );
+
+            return $target;
         }
 
         if ($accessorName === null) {

tests/src/IntegrationTest/WitherMethodTest.php

@@ -86,9 +86,12 @@ public function testWither(): void
         $this->assertNotSame($originalObject, $resultObject);
     }
 
+    /**
+     * @todo no longer throws exception, test the warning instead
+     */
     public function testChildImmutableSetterWithoutSetterOnParent(): void
     {
-        $this->expectException(NewInstanceReturnedButCannotBeSetOnTargetException::class);
+        // $this->expectException(NewInstanceReturnedButCannotBeSetOnTargetException::class);
 
         $source = new ParentObject();
         $target = new ParentObjectWithoutSetterDto();