perf(TransformerRegistry): Cache TransformerInterface instances.

rekalogika · Jan 18, 2024 · 705b44e · 705b44e
1 parent f06e184
commit 705b44e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@
 * perf: Remove type guesser from `TypeResolver`.
 * perf(`ObjectCache`): Optimize using plain arrays.
 * perf: Optimize `ObjectCache` & `Context`.
+* perf(`TransformerRegistry`): Cache `TransformerInterface` instances.
 
 ## 0.5.14
 

diff --git a/src/TransformerRegistry/CachingTransformerRegistry.php b/src/TransformerRegistry/CachingTransformerRegistry.php
@@ -29,9 +29,18 @@ public function __construct(
     ) {
     }
 
+    /**
+     * @var array<string,TransformerInterface>
+     */
+    private array $transformers = [];
+
     public function get(string $id): TransformerInterface
     {
-        return $this->decorated->get($id);
+        if (isset($this->transformers[$id])) {
+            return $this->transformers[$id];
+        }
+
+        return $this->transformers[$id] = $this->decorated->get($id);
     }
 
     public function findBySourceAndTargetTypes(

diff --git a/src/TransformerRegistry/TransformerRegistry.php b/src/TransformerRegistry/TransformerRegistry.php
@@ -32,8 +32,17 @@ public function __construct(
     ) {
     }
 
+    /**
+     * @var array<string,TransformerInterface>
+     */
+    private array $transformers = [];
+
     public function get(string $id): TransformerInterface
     {
+        if (isset($this->transformers[$id])) {
+            return $this->transformers[$id];
+        }
+
         $transformer = $this->transformersLocator->get($id);
 
         if (!$transformer instanceof TransformerInterface) {
@@ -44,7 +53,7 @@ public function get(string $id): TransformerInterface
             ));
         }
 
-        return $transformer;
+        return $this->transformers[$id] = $transformer;
     }
 
     /**