fix: Change ObjectCache to use WeakMap. Should improve memory usage.

CHANGELOG.md

@@ -22,6 +22,7 @@
 * revert: Revert support for `Generator` target type. Impossible to have a
   `Countable` result.
 * docs: Improve documentation
+* fix: Change `ObjectCache` to use `WeakMap`. Should improve memory usage.
 
 ## 0.5.3
 

src/ObjectCache/ObjectCache.php

@@ -23,20 +23,22 @@
 final class ObjectCache
 {
     /**
-     * @var \SplObjectStorage<object,\ArrayObject<string,object>>
+     * @var \WeakMap<object,\ArrayObject<string,object>>
      */
-    private \SplObjectStorage $cache;
+    private \WeakMap $cache;
 
     /**
-     * @var \SplObjectStorage<object,\ArrayObject<string,true>>
+     * @var \WeakMap<object,\ArrayObject<string,true>>
      */
-    private \SplObjectStorage $preCache;
+    private \WeakMap $preCache;
 
     public function __construct(
         private TypeResolverInterface $typeResolver
     ) {
-        $this->cache = new \SplObjectStorage();
-        $this->preCache = new \SplObjectStorage();
+        /** @psalm-suppress MixedPropertyTypeCoercion */
+        $this->cache = new \WeakMap();
+        /** @psalm-suppress MixedPropertyTypeCoercion */
+        $this->preCache = new \WeakMap();
     }
 
     private function isBlacklisted(mixed $source): bool
@@ -81,7 +83,7 @@ public function preCache(mixed $source, Type $targetType): void
             $this->preCache[$source] = $arrayObject;
         }
 
-        $this->preCache->offsetGet($source)->offsetSet($targetTypeString, true);
+        $this->preCache->offsetGet($source)?->offsetSet($targetTypeString, true);
     }
 
     private function isPreCached(mixed $source, Type $targetType): bool
@@ -181,7 +183,7 @@ public function saveTarget(
             $this->cache[$source] = $arrayObject;
         }
 
-        $this->cache->offsetGet($source)->offsetSet($targetTypeString, $target);
+        $this->cache->offsetGet($source)?->offsetSet($targetTypeString, $target);
         $this->removePrecache($source, $targetType);
     }
 }