dx: Clarity.

rekalogika · Jan 16, 2024 · d0149da · d0149da
1 parent 62e5260
commit d0149da
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * docs: Add rationale.
 * fix: Add variance safeguard.
+* dx: Clarity.
 
 ## 0.5.12
 

diff --git a/src/TransformerRegistry/TransformerRegistry.php b/src/TransformerRegistry/TransformerRegistry.php
@@ -59,7 +59,9 @@ public function findBySourceAndTargetType(
         $searchResultEntries = [];
 
         foreach ($mapping as $mappingEntry) {
-            if ($mappingEntry->isVariantTargetType() || !TypeCheck::isObject($targetType)) {
+            if ($mappingEntry->isVariantTargetType()) {
+                // if variant
+
                 $searchResultEntry = new SearchResultEntry(
                     mappingOrder: $mappingEntry->getOrder(),
                     sourceType: $sourceType,
@@ -70,6 +72,8 @@ public function findBySourceAndTargetType(
 
                 $searchResultEntries[] = $searchResultEntry;
             } else {
+                // if invariant, check if target type is somewhat identical
+
                 if (
                     TypeCheck::isSomewhatIdentical(
                         $targetType,