perf: Optimize guessTypeFromVariable

rekalogika · Jan 17, 2024 · d583183 · d583183
1 parent 9b3e99a
commit d583183
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 0.5.15
 
 * perf: Add caching for `TransformerRegistry`.
+* perf: Optimize `guessTypeFromVariable`
 
 ## 0.5.14
 

diff --git a/src/TypeResolver/TypeResolver.php b/src/TypeResolver/TypeResolver.php
@@ -23,35 +23,17 @@ class TypeResolver implements TypeResolverInterface
 {
     public function guessTypeFromVariable(mixed $variable): Type
     {
-        if (is_object($variable)) {
-            return TypeFactory::objectOfClass($variable::class);
-        }
-
-        if (is_null($variable)) {
-            return TypeFactory::null();
-        }
-
-        if (is_array($variable)) {
-            return TypeFactory::array();
-        }
-
-        if (is_bool($variable)) {
-            return TypeFactory::bool();
-        }
-
-        if (is_int($variable)) {
-            return TypeFactory::int();
-        }
+        $type = get_debug_type($variable);
 
-        if (is_float($variable)) {
-            return TypeFactory::float();
+        if (in_array($type, ['array', 'bool', 'int', 'float', 'string', 'null'])) {
+            return new Type($type);
         }
 
-        if (is_string($variable)) {
-            return TypeFactory::string();
+        if (class_exists($type)) {
+            return TypeFactory::objectOfClass($type);
         }
 
-        if (is_resource($variable)) {
+        if (\str_starts_with($type, 'resource')) {
             return TypeFactory::resource();
         }