fix: Fix static analysis issues.

rekalogika · Jan 24, 2024 · e8b1677 · e8b1677
1 parent fd3dc17
commit e8b1677
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.5.17
+
+* fix: Fix static analysis issues.
+
 ## 0.5.16
 
 * perf: Optimize `guessTypeFromVariable`

diff --git a/src/Command/MappingCommand.php b/src/Command/MappingCommand.php
@@ -63,23 +63,23 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $id = $entry->getId();
             $variantTargetType = $entry->isVariantTargetType();
 
-            if ($sourceOption) {
+            if ($sourceOption !== null) {
                 if (preg_match('/' . preg_quote($sourceOption) . '/i', $entry->getSourceTypeString()) === 0) {
                     continue;
                 }
 
                 $sourceType = preg_replace('/(' . preg_quote($sourceOption) . ')/i', '<bg=yellow>$1</>', $sourceType);
             }
 
-            if ($targetOption) {
+            if ($targetOption !== null) {
                 if (preg_match('/' . preg_quote($targetOption) . '/i', $entry->getTargetTypeString()) === 0) {
                     continue;
                 }
 
                 $targetType = preg_replace('/(' . preg_quote($targetOption) . ')/i', '<bg=yellow>$1</>', $targetType);
             }
 
-            if ($classOption) {
+            if ($classOption !== null) {
                 if (
                     preg_match('/' . preg_quote($classOption) . '/i', $entry->getClass()) === 0
                     && preg_match('/' . preg_quote($classOption) . '/i', $entry->getId()) === 0

diff --git a/src/TypeResolver/CachingTypeResolver.php b/src/TypeResolver/CachingTypeResolver.php
@@ -37,7 +37,8 @@ public function __construct(
 
     public function getTypeString(Type|MixedType $type): string
     {
-        if ($result = $this->typeStringCache[$type] ?? null) {
+        $result = $this->typeStringCache[$type] ?? null;
+        if ($result !== null) {
             return $result;
         }
 
@@ -62,7 +63,8 @@ public function getSimpleTypes(Type|MixedType $type): array
 
         $key = rawurlencode(serialize($type));
 
-        if ($result = $this->simpleTypesCache[$key] ?? null) {
+        $result = $this->simpleTypesCache[$key] ?? null;
+        if ($result !== null) {
             return $result;
         }