Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ObjectToObjectTransformer): Prevent delegating to MainTransformer if the current value in a dynamic property is a scalar. #35

Merged
merged 1 commit into from
Feb 21, 2024
Merged

perf(ObjectToObjectTransformer): Prevent delegating to MainTransformer if the current value in a dynamic property is a scalar. #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
* fix: mapping to object extending `stdClass` to property with no setter.
* feat: `stdClass` to `stdClass` mapping should work correctly.
* feat: Mapping to existing values in a dynamic property.
* perf(`ObjectToObjectTransformer`): Prevent delegating to `MainTransformer` if
the current value in a dynamic property is a scalar.

## 1.0.0

Expand Down
5 changes: 4 additions & 1 deletion src/Transformer/Implementation/ObjectToObjectTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,10 @@ private function mapDynamicProperties(
}


if ($currentTargetPropertyValue === null) {
if (
$currentTargetPropertyValue === null
|| is_scalar($currentTargetPropertyValue)
) {
/** @psalm-suppress MixedAssignment */
$targetPropertyValue = $sourcePropertyValue;
} else {
Expand Down