Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static analysis fixes #49

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix: static analysis fixes #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/CustomMapper/Implementation/PropertyMapperResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ public function getPropertyMapper(
}
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());

foreach (class_implements($targetClass) as $interface) {
$interfaces = class_implements($sourceClass);
if ($interfaces === false) {
return null;
}

foreach ($interfaces as $interface) {
if (isset($propertyMappers[$interface])) {
return $propertyMappers[$interface];
}
Expand Down
7 changes: 6 additions & 1 deletion src/CustomMapper/ObjectMapperTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,12 @@ public function getObjectMapper(
}
} while ($sourceClassReflection = $sourceClassReflection->getParentClass());

foreach (class_implements($targetClass) as $interface) {
$interfaces = class_implements($sourceClass);
if ($interfaces === false) {
return null;
}

foreach ($interfaces as $interface) {
if (isset($propertyMappers[$interface])) {
return $propertyMappers[$interface];
}
Expand Down
14 changes: 12 additions & 2 deletions src/Util/TypeUtil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,21 @@ private static function getAllClassesFromObject(
$class = is_object($objectOrClass) ? $objectOrClass::class : $objectOrClass;
$classes[] = $class;

foreach (class_parents($class) as $parentClass) {
$parents = class_parents($class);
if ($parents === false) {
$parents = [];
}

foreach ($parents as $parentClass) {
$classes[] = $parentClass;
}

foreach (class_implements($class) as $interface) {
$interfaces = class_implements($class);
if ($interfaces === false) {
$interfaces = [];
}

foreach ($interfaces as $interface) {
$classes[] = $interface;
}

Expand Down