Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the footer slightly bigger #262

Closed

Conversation

siteshwar
Copy link
Contributor

... to make it easier to read.

@siteshwar
Copy link
Contributor Author

Current default size of the footer may be too hard for some users to read. It can be seen on the Fedora deployment.

This is a screenshot from OpenScanHub with the requested change:

screenshot

Copy link
Contributor

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siteshwar I'm don't think that the text in a footer should be bigger than the actual main text in menus or the main content as shown in your picture.

edit: Of course, I agree that the current text size is too small.

@siteshwar
Copy link
Contributor Author

@siteshwar I'm don't think that the text in a footer should be bigger than the actual main text in menus or the main content as shown in your picture.

I can set font-size: 85%; for the footer. I need somebody else to clarify what would be an acceptable size for it.

@siteshwar
Copy link
Contributor Author

@rohanpm Would it be possible for you to comment on it?

... to make it easier to read.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Copy link
Contributor Author

@siteshwar I'm don't think that the text in a footer should be bigger than the actual main text in menus or the main content as shown in your picture.

I can set font-size: 85%; for the footer. I need somebody else to clarify what would be an acceptable size for it.

I have set it to 85% for now.

@siteshwar
Copy link
Contributor Author

@rohanpm Can we merge this?

@siteshwar
Copy link
Contributor Author

Closing in favor of openscanhub/openscanhub#291

@siteshwar siteshwar closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants