Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egor ask-and-tell interface #116

Merged
merged 13 commits into from
Nov 30, 2023
Merged

Egor ask-and-tell interface #116

merged 13 commits into from
Nov 30, 2023

Conversation

relf
Copy link
Owner

@relf relf commented Nov 19, 2023

This PR refactors the Egor API to make a proper ask-and-tell interface with Python binding. It involves some breaking changes in the API

  • Configuration of Egor is factorize out in EgorConfig
  • EgorBuilder gets a configure method to tune the configuration
  • EgorService structure represent Egor when used as service
  • Python Egor API changes:
    • function under optimization is now given via minimize(fun, max_iters=...) method
    • new method suggest(xdoe, ydoe) allows to ask for x suggestion and tell current function evaluations
    • new method get_result(xdoe, ydoe) to get the best evaluation (ie minimum) from given ones

@relf relf marked this pull request as ready for review November 30, 2023 14:51
@relf relf merged commit 2227e1b into master Nov 30, 2023
13 checks passed
@relf relf deleted the py-ask-and-tell branch November 30, 2023 15:51
@relf relf mentioned this pull request Dec 14, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant