Open
Conversation
Lua strings are not UTF-8 and so it is incorrect to use Rust strings. In particular, some Lua libraries specifically designed to add support for Unicode, like ustring, use `string.find` to look for non-ASCII characters in Lua strings, which is impossible to do when Lua strings are treated as UTF-8 (a character set of `[\x80-\xff]` is ill-formed). This is an API-breaking change. Note that downstream consumers like piccolo will now convert using `IntoValue for Vec<T>` instead of `IntoValue for StdString` and so those need to be changed to call `ctx.intern` explicitly instead of relying on the auto-conversion.
csnover
force-pushed
the
byte-strings
branch
from
03c9e49 to
af5fbb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lua strings are not UTF-8 and so it is incorrect to use Rust strings. In particular, some Lua libraries specifically designed to add support for Unicode, like ustring, use
string.findto look for non-ASCII characters in Lua strings, which is impossible to do when Lua strings are treated as UTF-8 (a character set of[\x80-\xff]is ill-formed).This is an API-breaking change.
Note that downstream consumers like piccolo will now convert using
IntoValue for Vec<T>instead ofIntoValue for StdStringand so those need to be changed to callctx.internexplicitly instead of relying on the auto-conversion.