Open
Conversation
PIL 20.2: An upper case version of any of those classes represents the complement of the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIL 20.2: An upper case version of any of those classes represents the complement of the class.
The complements were in the test suite for bare pattern but not for character set, where they were failing. This patch adds a basic test for complement class in a character set.
The implementation looks a little weird. The list of bytes is an ordered list of transition points, not ranges, and the simple inversion trick requires exclusive end indexes. There might be a cleaner and equally or more efficient way to do this but I am a smooth brain.