Small tweaks

remix-run · Nov 7, 2019 · 50997b3 · 50997b3
1 parent 2acce39
commit 50997b3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/modules/__tests__/createBrowserHistory-test.js b/modules/__tests__/createBrowserHistory-test.js
@@ -35,16 +35,14 @@ describe('a browser history', () => {
   });
 
   it('does not encode the generated path', () => {
-    // encoded
     const encodedHref = history.createHref({
       pathname: '/%23abc'
     });
-    // unencoded
+    expect(encodedHref).toEqual('/%23abc');
+
     const unencodedHref = history.createHref({
       pathname: '/#abc'
     });
-
-    expect(encodedHref).toEqual('/%23abc');
     expect(unencodedHref).toEqual('/#abc');
   });
 

diff --git a/modules/__tests__/createHashHistory-test.js b/modules/__tests__/createHashHistory-test.js
@@ -39,16 +39,14 @@ describe('a hash history', () => {
   });
 
   it('does not encode the generated path', () => {
-    // encoded
     const encodedHref = history.createHref({
       pathname: '/%23abc'
     });
-    // unencoded
+    expect(encodedHref).toEqual('#/%23abc');
+
     const unencodedHref = history.createHref({
       pathname: '/#abc'
     });
-
-    expect(encodedHref).toEqual('#/%23abc');
     expect(unencodedHref).toEqual('#/#abc');
   });
 

diff --git a/modules/__tests__/createMemoryHistory-test.js b/modules/__tests__/createMemoryHistory-test.js
@@ -34,16 +34,14 @@ describe('a memory history', () => {
   });
 
   it('does not encode the generated path', () => {
-    // encoded
     const encodedHref = history.createHref({
       pathname: '/%23abc'
     });
-    // unencoded
+    expect(encodedHref).toEqual('/%23abc');
+
     const unencodedHref = history.createHref({
       pathname: '/#abc'
     });
-
-    expect(encodedHref).toEqual('/%23abc');
     expect(unencodedHref).toEqual('/#abc');
   });