Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npm deploy cmd to cloudflare template #58

Closed
wants to merge 1 commit into from

Conversation

jgresham
Copy link

No description provided.

@brookslybrand
Copy link
Contributor

@jgresham thanks for opening a PR. I think the instructions in the README make it pretty clear how to deploy the cloudflare template, including preview deploys, so I don't think we're going to merge this one in. For people who want a deploy command it's easy enough to add like you did.

@brookslybrand
Copy link
Contributor

@jgresham I changed my mind on this and decided to add it in #63 for both the cloudflare and cloudflare-d1 templates. I think it's useful to automatically build before you deploy, rather than expecting the developer to remember each of those steps.

Thanks for the original PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants