-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vite 6 support #12469
Add Vite 6 support #12469
Conversation
🦋 Changeset detectedLatest commit: 98e8c25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I made these PR to remix while testing Vite 6. I didn't try them with RR7, but it might be useful. |
@@ -85,7 +85,7 @@ | |||
"semver": "^7.3.7", | |||
"set-cookie-parser": "^2.6.0", | |||
"valibot": "^0.41.0", | |||
"vite-node": "^1.6.0" | |||
"vite-node": "3.0.0-beta.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was bumped because v3 is the first major version of vite-node to officially support both Vite v5 and v6: https://github.com/vitest-dev/vitest/blob/main/packages/vite-node/package.json#L89. I think it's okay we're running a beta version because we're using vite-node in a very limited capacity to run config files and we don't expose any Vite internals to consumers. However, just to be sure, we run the routes.ts tests against both v5 and v6 of Vite.
@sapphi-red Thanks for your help on the Remix repo. I've applied your HMR fix here, and I've also adjusted my approach for using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that I pair reviewed these changes with @pcattori.
Great that it's merged 🙂 It would be nice if we can have RR7 in the ecosystem-ci as well. |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Tasks:
typecheck
command