Decouple CLI arg parsing/execution for NODE_ENV initialization #12505
Conversation
🦋 Changeset detectedLatest commit: 2fe399b The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| let { input, flags, command } = parseArgs(); | ||
|
|
||
| // If not already set, default `NODE_ENV` so React loads the proper | ||
| // version in it's CJS entry script. We have to do this before importing `run.ts` | ||
| // since that is what imports `react` (indirectly via `react-router`) | ||
| if (command === "dev") { | ||
| process.env.NODE_ENV = process.env.NODE_ENV ?? "development"; | ||
| } else { | ||
| process.env.NODE_ENV = process.env.NODE_ENV ?? "production"; | ||
| } |
There was a problem hiding this comment.
Parse args and set NODE_ENV first
| import("./run").then(({ run }) => { | ||
| run(input, flags, command).then( | ||
| () => { | ||
| process.exit(0); | ||
| }, | ||
| (error: unknown) => { | ||
| if (error) console.error(error); | ||
| process.exit(1); | ||
| } | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Then run the CLI
| * Parse command line arguments for `react-router` dev CLI | ||
| */ | ||
| export function parseArgs(argv: string[] = process.argv.slice(2)) { | ||
| // Check the node version |
There was a problem hiding this comment.
No changes to this logic, just extracted out from run() below
|
|
||
| // If not already set, default `NODE_ENV=production` so React loads the proper | ||
| // version in it's CJS entry script | ||
| process.env.NODE_ENV = process.env.NODE_ENV ?? "production"; |
There was a problem hiding this comment.
Set this correctly before calling the CLI so the proper version of React gets loaded (#12078)
| @@ -9,6 +9,7 @@ import pkg from "./package.json"; | |||
|
|
|||
| const entry = [ | |||
| "cli/index.ts", | |||
| "cli/run.ts", | |||
There was a problem hiding this comment.
Needed to make run it's own entry point so it can be lazily imported as runtime
There was a problem hiding this comment.
hm, well that didn't fix CI so may need to dig into this part a bit deeper
|
Closing this because this reorg causes a node 22.12 cyclical dependency issue in |
|
New PR: #12578 |
It seems React 19 is a bit more strict with
NODE_ENVand when it's not set by the user there is currently a mismatch between our code and React's code (similar to the issue in #12078)productionwhen we callvite.resolveConfigin inplugin.tsdevelopmentThis mismatch causes issues because we end up with mismatched versions of React in the bundle versus the
react-router buildruntime.The import chain to get to
reactisrun.ts -> commands.ts -> plugin.ts -> react-router -> react, and we probably want our default value to be conditional based on the command (similar to what vite does). This PR does 2 things:loadPluginContextout to it's ownplugin-context.tsfile so that it can be loaded fromcommands.tswithout also loadingreact-routerwhich loadsreactand evaluates the value ofNODE_ENVrun.tsinto a newparse.tsso we can run that up front in isolation, then set the properNODE_ENVbased on the commandThis way, running the CLI will not load
react-router/reactuntil after we've properly initializedNODE_ENVCloses #12138, #12078