Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisite sections to a few places #12559

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

knownasilya
Copy link
Contributor

This bit me, I started updating and a ways into the update got the startTransition is not a function error. Almost on 18, but not yet, so a note on the docs site would have saved some frustration/time.

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: a6dd3e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 16, 2024

Hi @knownasilya,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 16, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brookslybrand
Copy link
Contributor

Thanks @knownasilya for adding this. I made a couple of changes:

  • Move the callouts to <docs-layout> (see screen shot) instead of an additional h1
  • removed installGlobals -- this was a Remix thing, so mentioning it on the React Router upgrade docs only has the potential to add confusion. It's discussed in the Remix future flags doc, which is step 1 of upgrading from Remix
Screenshot 2024-12-16 at 11 28 08 AM

@brookslybrand brookslybrand merged commit c16f257 into remix-run:main Dec 16, 2024
3 checks passed
@knownasilya knownasilya deleted the patch-1 branch December 16, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants