Skip to content

Conversation

kirillgroshkov
Copy link

@kirillgroshkov kirillgroshkov commented Sep 23, 2025

Implements this proposal: #14080

closes #14383

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2025

🦋 Changeset detected

Latest commit: 48a5147

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2025

Hi @kirillgroshkov,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 linked an issue Sep 24, 2025 that may be closed by this pull request
@brophdawg11
Copy link
Contributor

You can add a changeset via pnpm changeset - this would be a patch (because it's not a stable feature yet) for @react-router/dev

@brophdawg11
Copy link
Contributor

ok I think this is looking good. I'll cut an alpha release from this branch later today and do some testing and get this in front of some other folks for a review 👍

@brophdawg11
Copy link
Contributor

This is available for alpha testing in 0.0.0-experimental-afe1c2609. All looked good on my local testing.

@remix-run remix-run deleted a comment from Samiullahstanikzai Sep 28, 2025
@brookslybrand
Copy link
Contributor

brookslybrand commented Sep 30, 2025

Confirmed that this does in fact build the remix docs faster 🚀

On my machine, unstable_concurrency: 4 went from 18.58s to 8.78s

@brophdawg11 brophdawg11 self-assigned this Oct 21, 2025
@brophdawg11
Copy link
Contributor

I talked to @pcattori and we decided to just use this as a dep instead of vendoring so pushed up that change and will plan to get this merged after CI passes 👍

@timdorr
Copy link
Member

timdorr commented Oct 21, 2025

Are you sure about that? 🤔
image

@timdorr
Copy link
Member

timdorr commented Oct 21, 2025

Nevermind! That's mostly from the merge in of dev into this branch. Not sure why it's so big, but it's just a single addition in b30a470.

@brophdawg11
Copy link
Contributor

lol looks like our version of the lockfile in dev is using single quotes and when I resolved merge conflicts and saved in my IDE, it applied prettier and changed it all to double quotes. I reverted it back and will apply prettier to the dev version after I merge to get us back onto double quotes.

@brophdawg11 brophdawg11 merged commit 57925f1 into remix-run:dev Oct 21, 2025
8 checks passed
@brophdawg11 brophdawg11 removed their assignment Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prerendering with concurrency

4 participants