fix(react-router): run action handlers for routes with middleware even if no loader is present #14443
+77
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n if no loader is present
🦋 Changeset detectedLatest commit: 7e53983 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
reviewed
Oct 23, 2025
| middleware && middleware.length > 0 && !loader && !lazy; | ||
| middleware && middleware.length > 0 && !loader && !action && !lazy; | ||
|
|
||
| if (callHandler && !isMiddlewareOnlyRoute) { |
There was a problem hiding this comment.
Suggested change
| if (callHandler && !isMiddlewareOnlyRoute) { | |
| if (callHandler && (isMutationMethod(request.method) || !isMiddlewareOnlyRoute)) { |
brophdawg11
reviewed
Oct 23, 2025
brophdawg11
approved these changes
Oct 23, 2025
|
🤖 Hello there, We just published version Thanks! |
|
thank you! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14429
Previously, routes that only defined an action and had middleware could fail to
invoke the action unless at least one loader was present in the matched route tree.
This patch ensures the middleware execution path correctly handles action-only routes by always executing the
action phase even when no loaders are found.