Skip to content

chore(dev): drop vite-node dependency#14862

Open
vixalien wants to merge 1 commit intoremix-run:devfrom
vixalien:chore/drop-vite-node
Open

chore(dev): drop vite-node dependency#14862
vixalien wants to merge 1 commit intoremix-run:devfrom
vixalien:chore/drop-vite-node

Conversation

@vixalien
Copy link
Copy Markdown

This PR configures @react-router/dev to load it's config file using vite directly, instead of using vite-node.

vite-node has "finished it's mission" according to it's README, because it's capabilities can now be done with Vite natively.

[...] which means vite-node has finished its mission. We will still keep it around for the ecosystem that built around it, but for new projects, please consider using the builtin Vite one instead.

I ported react router to use vite directly according to instructions at antfu-collective/vite-node#11 (comment)

Please let me know if anything else is needed or more details are needed. I believe loading directly via vite-node will be faster (not benchmarked)

@remix-cla-bot
Copy link
Copy Markdown
Contributor

remix-cla-bot Bot commented Mar 10, 2026

Hi @vixalien,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Copy Markdown
Contributor

remix-cla-bot Bot commented Mar 10, 2026

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@vixalien vixalien changed the base branch from main to dev March 10, 2026 02:25
@vixalien
Copy link
Copy Markdown
Author

Oops, can't figure out how to fix the tests. help appreciated

@github-actions
Copy link
Copy Markdown
Contributor

👋 We've moved away from Changesets to our own internal changes process. Please convert your changesets file to a change file in the proper package directory (i.e., packages/react-router/.changes/patch.fix-some-bug.md).

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Apr 15, 2026
@MichaelDeBoey MichaelDeBoey changed the title chore: drop vite-node dependency chore(dev): drop vite-node dependency Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed dependencies Pull requests that update a dependency file feat:vite pkg:@react-router/dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants