Skip to content

fix(types): remove deprecated FormEventHandler override from SharedFormProps #14932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
restareaByWeezy wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −7
Open

fix(types): remove deprecated FormEventHandler override from SharedFormProps #14932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80cd9a3
fix(types): remove deprecated FormEventHandler override from SharedFo…
restareaByWeezy Mar 26, 2026
bf968a1
chore: sign CLA and add changeset
restareaByWeezy Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-form-onsubmit-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-router": patch
---

Remove explicit `onSubmit` type override from `SharedFormProps` to fix deprecation warning with `@types/react@19.x`
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@
- refusado
- remorses
- renyu-io
- restareaByWeezy
- reyronald
- RFCreate
- richardkall
Expand Down
7 changes: 0 additions & 7 deletions packages/react-router/lib/dom/lib.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1770,13 +1770,6 @@ interface SharedFormProps extends React.FormHTMLAttributes<HTMLFormElement> {
*/
preventScrollReset?: boolean;

/**
* A function to call when the form is submitted. If you call
* [`event.preventDefault()`](https://developer.mozilla.org/en-US/docs/Web/API/Event/preventDefault)
* then this form will not do anything.
*/
onSubmit?: React.FormEventHandler<HTMLFormElement>;

/**
* Specify the default revalidation behavior after this submission
*
Expand Down
Loading