Skip to content

fix(dev): ignore external Vite server environments#14938

Open
raashish1601 wants to merge 2 commits intoremix-run:devfrom
raashish1601:contributor-04/react-router-14937
Open

fix(dev): ignore external Vite server environments#14938
raashish1601 wants to merge 2 commits intoremix-run:devfrom
raashish1601:contributor-04/react-router-14937

Conversation

@raashish1601
Copy link
Copy Markdown

Closes #14937.

Summary

  • only treat ssr / ssrBundle_* as React Router-owned server environments
  • skip the server-build manifest cleanup path for unrelated environments added by other Vite plugins
  • add focused Jest coverage for the server-environment filtering logic

Validation

  • corepack pnpm test packages/react-router-dev/__tests__/vite-plugin-test.ts
  • corepack pnpm --filter @react-router/dev build

@remix-cla-bot
Copy link
Copy Markdown
Contributor

remix-cla-bot Bot commented Mar 27, 2026

Hi @raashish1601,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@p-dubovitsky
Copy link
Copy Markdown

A duplicate of #14883

@remix-cla-bot
Copy link
Copy Markdown
Contributor

remix-cla-bot Bot commented Mar 28, 2026

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@raashish1601
Copy link
Copy Markdown
Author

Compared this against #14883 in detail. There is overlap in packages/react-router-dev/vite/plugin.ts, but the two PRs are not identical today: #14883 only gates the writeBundle / prerender SSR-only paths, while this branch also threads the React Router server-environment filter through configEnvironment() and the shared getServerEnvironmentEntries() / getServerEnvironmentKeys() helper used by the environment-config path, with direct unit coverage in packages/react-router-dev/__tests__/vite-plugin-test.ts.

If you'd prefer to keep a single branch, I'm happy to fold the configEnvironment / helper coverage into #14883 instead. I also pushed 012c9c0 to add raashish1601 to contributors.yml so the CLA bot can re-check this branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 We've moved away from Changesets to our own internal changes process. Please convert your changesets file to a change file in the proper package directory (i.e., packages/react-router/.changes/patch.fix-some-bug.md).

@github-actions github-actions Bot deleted a comment from changeset-bot Bot Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants