route-pattern: Add some (failing?) edge cases #10729
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @pcattori since you seem to be actively working on the route-pattern package |
There was a problem hiding this comment.
Pull Request Overview
This PR adds test cases to verify how the route-pattern library handles non-ASCII characters in URL patterns and matching, including Arabic text, accented characters, and emojis. The tests explore potential edge cases that may not be properly handled by the current implementation.
- Added four new test cases covering internationalization scenarios
- Tests both parameter extraction and static pattern matching with Unicode characters
- Highlights potential encoding/decoding inconsistencies with non-ASCII URL components
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is by design, or if it's an overlooked edge case, so I'm opening this PR to highlight some mismatches when using accents / arabic / emojis in URL.
PHP, for example, automatically decodes these for me.