-
Notifications
You must be signed in to change notification settings - Fork 443
feature/fish completion #2463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature/fish completion #2463
Conversation
|
im going to temporarily not fail the dejagnu tests as not able to run dejagnu on osx. (fails when running fish) |
|
Hi @maxandersen thank you for helping push this forward. I see this one test that now seems to be failing for some reason: Does this need to be added to {
"name" : "picocli.AutoComplete$GenerateCompletion$Shell",
"allDeclaredConstructors" : true,
"allPublicConstructors" : true,
"allDeclaredMethods" : true,
"allPublicMethods" : true
}, |
|
sounds about right. pushed. |
|
the failure on java 9 is that it does not seem available on github actions? |


rebased #1925 as I realized fish now works with jbang scripts so I got a good reason to make this work :)
I've added basic support to the GenerateCompletion command for choosing which variant to generate bash/zsh or fish.
But I didn't grok what the meaning is for the AutoComplete which generates code does does not run without user modification so i did not add/change that.
I've tested it in jbang at jbangdev/jbang#2195 and would love to see a picocli release with this included so I can release jbang with fish completion :)