Fix propagation of 'device' setting from 'models.load_network' to `la…#2
Open
egorssed wants to merge 1 commit intoreml-lab:mainfrom
Open
Fix propagation of 'device' setting from 'models.load_network' to `la…#2egorssed wants to merge 1 commit intoreml-lab:mainfrom
egorssed wants to merge 1 commit intoreml-lab:mainfrom
Conversation
…yer.TimeEmbedding`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your paper and code!
I was trying to run it on my Mac m1, that has cpu only, but setting device with load_network lead to error.
This is because
net.to(device)is just not enough. You see,layer.TimeEmbeddingexplicitly puts data toself.device,and setting
net.to(device)doesn't change the field of classlayer.TimeEmbedding.devicehetvae/src/layers.py
Line 32 in 78296e2
The solution is just propagate the field
self.devicestraight through themodels.load_networktolayer.TimeEmbeddingas it is done in the pull request.Otherwise just get rid of explicit moving to device in
layer.TimeEmbeddingif it is not needed anymore.