[CN] Make CN run both Z3 and CVC5 in CI, tidy up runner CI script #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septract
changed the title
|
TODO: perhaps do the same for the cerberus-local test suite (run by the |
septract
changed the title
|
CI now fails because z3 and cvc5 have different timing characteristics, so one example times out with cvc5. Annoying problem, unsure what to do about it. |
|
Longer timeout?
…On Tue, Jul 9, 2024 at 8:59 PM Mike Dodds ***@***.***> wrote:
CI now fails because z3 and cvc5 have different timing characteristics, so
one example times out with cvc5. Annoying problem, unsure what to do about
it.
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/rems-project/cerberus/pull/365*issuecomment-2219258118__;Iw!!IBzWLUs!TI7QG5TNde6s6OsVQdTWgIT5fIfM_dgx068mXmrlC6q3x5yc4DLsLbO_EN0vLNIYBhuUfhmP0D5mUBZbrU8Eju15Qj-V$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVQQC5IMAO57E3TYIYEHLTZLSBN7AVCNFSM6AAAAABKNZPGFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZGI2TQMJRHA__;!!IBzWLUs!TI7QG5TNde6s6OsVQdTWgIT5fIfM_dgx068mXmrlC6q3x5yc4DLsLbO_EN0vLNIYBhuUfhmP0D5mUBZbrU8EjuFr3ar1$>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I've bumped up the timeout for now and merged this. We would like the CI to find regressions in timing behaviour, though. So we'll probably want to extend our scripts to collect timing statistics and "publish" the results in a way that allows for easy comparison across commits + fail if the overall sum exceed some sensible limit. |
elaustell
pushed a commit
to rems-project/cn-tutorial
that referenced
this pull request
Jul 17, 2024
|
@cp526 Agreed, I made an issue to capture this idea here: rems-project/cn-tutorial#54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: depends on this PR in the
cn-tutorialrepo, which fixes a bug in the runner script handling ofcnarguments.This PR also significantly tides up the runner script and shifts most of the logic over to the
cn-tutorialMakeFile, and fixes a bug that was stopping some tests from running.