Properly defining two calling conventions for Core #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change during recursion
* Normal_callconv: the original and default one, where the elaboration of C parameters are passed by pointers (to temporary objects allocated and initialised by the caller). * Inner_arg_callconv: used by CN, where the elaboration of C parameters are passed by value (except for the additional parameters of variadic functions) and the temporary objects are allocated by the callee in its body. This commit updates the Core typing and runtime to support both calling conventions.
kmemarian
force-pushed
the
callconv_for_core
branch
from
9f2b903 to
e9280de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Core and its runtime to fully support two calling conventions differing on whether temporary objects for parameters are allocated by the caller (default) or the callee (the
inner_arg_tempsswitch used by CN).This should address issue #391.