Close the files after comparing them.#17
Closed
lastland wants to merge 1 commit intorems-project:masterfrom
Closed
Close the files after comparing them.#17lastland wants to merge 1 commit intorems-project:masterfrom
lastland wants to merge 1 commit intorems-project:masterfrom
Conversation
Author
|
I suppose Windows does not allow you to remove a file which is not closed. |
emersion
approved these changes
Aug 10, 2018
Contributor
|
This was superseded by 8942774. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
same_content_filesdoes not close the files after comparing them. This causes the second problem described in #16. And this PR fixes #16.