feat(ci): add Lean testing in the CI #871
Conversation
…h EEXIST If the directory already exist, it's fine, no need to fail with EEXIST. This fixes the situation where the bug already exist. Signed-off-by: Raito Bezarius <[email protected]>
|
I noticed that Lean tests are actually already covered by the test coverage job, I will remove the extension of the core tests and change this to build the emitted Lean project. |
/bin/bash is not guaranteed to exist on all Linux distributions, NixOS does not have one. Prefer `/usr/bin/env` which should really (empirically) always exist. Signed-off-by: Raito Bezarius <[email protected]>
Restovers can remains due to spurious failures as we are not catching exceptions in the middle that may prevent the final `rm` to run. If we are not doing that, the next run will cause EEXIST errors. Signed-off-by: Raito Bezarius <[email protected]>
RaitoBezarius
force-pushed
the
lean-ci
branch
from
a558385 to
399e99a
Compare
|
@javra This is ready now, I think. |
RaitoBezarius
force-pushed
the
lean-ci
branch
3 times, most recently
from
5f294bb to
e7e5674
Compare
|
Maybe |
RaitoBezarius
force-pushed
the
lean-ci
branch
from
e7e5674 to
8c81939
Compare
|
bash will treat |
This reuses the various lean-toolchain information and download an ad-hoc Lean version based on this. Signed-off-by: Raito Bezarius <[email protected]>
RaitoBezarius
force-pushed
the
lean-ci
branch
from
8c81939 to
897ed19
Compare
I was not sure that |
Test Results 12 files ±0 24 suites ±0 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit 897ed19. ± Comparison against base commit 153c7b6. |
|
Besides |
| uses: actions/cache/restore@v3 | ||
| with: | ||
| path: ~/.elan | ||
| key: ${{ matrix.os }}-${{ matrix.version }}-cov |
There was a problem hiding this comment.
Can we use the same key here as our opam cache, or will they end up clobbering each other?
There was a problem hiding this comment.
I think they are going to clobber each other actually.
There was a problem hiding this comment.
(so I would prefix the key by elan-)
During my local tests, warnings does not cause nonzero exit status and does not make the pipeline fail. But yeah. |
This ensures that all changes to the Lean backend are tested by recompiling the Lean files with Lean itself via the coverage CI entrypoint.
I'm not exactly sure if you are fine with the solution to install Lean, I have other options:
Let me know what you prefer and I will adapt this PR. Additionally, I have a Nix scaffolding setup (default/shell) which is quite popular for people working on that environment, if you are interested into me contributing it, please let me know. I can also take maintenance ownership on that if needed, obviously.
cc @javra
Signed-off-by: Raito Bezarius [email protected]